Skip to content

WIP - language status for partial mode #17703

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

jrieken
Copy link
Member

@jrieken jrieken commented Oct 12, 2021

When running in a limited context, like github.dev, it should be made clear that language support isn't at the same level as in desktop or codespaces. With TypeScript and anycode we have settled on some best practice and wording. This PR is WIP towards that uniform UX/language (more details at https://github.com/microsoft/vscode-dev/issues/300)

There is still a few open questions, namely

  • the wording for "details" needs to be tweaked
  • create aka.ms-link for the "Learn More" and fill it with content
  • (engineering) I wasn't able to use the localize-util, importing src/client/common/utils/localize.ts fails to webpack
  • (engineering) unsure if I am updating/using that API proposal correcty

@jrieken jrieken marked this pull request as draft October 12, 2021 14:31
@karthiknadig
Copy link
Member

@jrieken Thanks for looking into this, we have a PR (#17658) up for this that @karrtikr is taking care of the wording with the pylance team.

@karrtikr karrtikr deleted the joh/webLanguageStatus branch October 12, 2021 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants