Skip to content

Prelimnary support to load ipyn files in native Notebook editor - #11841

Merged
Don Jayamanne (DonJayamanne) merged 8 commits into
microsoft:masterfrom
DonJayamanne:addToMaster
May 15, 2020
Merged

Prelimnary support to load ipyn files in native Notebook editor#11841
Don Jayamanne (DonJayamanne) merged 8 commits into
microsoft:masterfrom
DonJayamanne:addToMaster

Conversation

@DonJayamanne

Copy link
Copy Markdown

For #10496

  • If user is in notebook experiment, then make changes to package.json
  • Got some tests that I need to add, trying to pick apart prototype from real..

Comment thread package.json Outdated
Comment thread package.json Outdated
Comment thread src/client/datascience/notebook/integration.ts Outdated
Comment thread package.json Outdated
Comment thread experiments.json
Comment thread src/client/common/constants.ts
Comment thread src/client/datascience/notebook/contentProvider.ts
Comment thread src/client/datascience/notebook/contentProvider.ts Outdated
Comment thread src/client/datascience/notebook/helpers.ts

@rchiodo Rich Chiodo (rchiodo) left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@DonJayamanne

Copy link
Copy Markdown
Author

Rich Chiodo (@rchiodo)

  • Updated as requested.
  • CI Check fails and ensures no one adds this accidentally
    Screen Shot 2020-05-15 at 14 40 56

@codecov-io

Codecov (codecov-io) commented May 15, 2020

Copy link
Copy Markdown

Codecov Report

Merging #11841 into master will decrease coverage by 60.68%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #11841       +/-   ##
===========================================
- Coverage   60.68%    0.00%   -60.69%     
===========================================
  Files         629       12      -617     
  Lines       33985       37    -33948     
  Branches     4781        4     -4777     
===========================================
- Hits        20625        0    -20625     
+ Misses      12368       37    -12331     
+ Partials      992        0      -992     
Impacted Files Coverage Δ
src/client/constants.ts 0.00% <0.00%> (-100.00%) ⬇️
src/client/debugger/constants.ts 0.00% <0.00%> (-100.00%) ⬇️
src/client/common/process/constants.ts 0.00% <0.00%> (-100.00%) ⬇️
src/client/common/platform/constants.ts 0.00% <0.00%> (-100.00%) ⬇️
src/client/interpreter/autoSelection/constants.ts 0.00% <0.00%> (-100.00%) ⬇️
src/client/interpreter/locators/services/conda.ts 0.00% <0.00%> (-100.00%) ⬇️
...t/datascience/jupyter/jupyterDataRateLimitError.ts 0.00% <0.00%> (-50.00%) ⬇️
...ess/internal/scripts/vscode_datascience_helpers.ts
...c/client/typeFormatters/codeBlockFormatProvider.ts
src/client/language/textIterator.ts
... and 611 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2505b6a...a121c63. Read the comment docs.

@sonarqubecloud

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 4 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@DonJayamanne
Don Jayamanne (DonJayamanne) merged commit bbfec89 into microsoft:master May 15, 2020
@DonJayamanne
Don Jayamanne (DonJayamanne) deleted the addToMaster branch May 15, 2020 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-changelog No news entry required

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants