Remove debugOptions when using python debug adapter

[karthiknadig]

[luabud]

@karthiknadig is this stale?

[karthiknadig]

No, we still send this. The debugger supports this for backwards compatibility. We should remove this.

[karthiknadig]

@int19h I am planning on removing this. The only thing I am a bit concerned about is the ideOS thing in setDebuggerProperty. Currently we seem to require it and send it via debugOptions. Is there any other way to do this or do we need to preserve this in the extension?

Another item is FixFilePathCase, currently we use this to "Fix" file paths to match what VS Code expects.

/cc @paulacamargo25 FYI

[int19h]

I'm confused re setDebuggerProperty("ideOS") - isn't that distinct from debugOptions?

Looking at pydevd source, it's not clear to me how FixFilePathCase and WindowsClient/UnixClient are propagated, or even if they're propagated at all. @fabioz, is any of that still needed?

[karthiknadig]

Currently we get it like this in debugpy from debugOptions:

[int19h]

Ah, I see what you mean now. Yeah, looks like we need to add the OS type here. I'm not sure if we still need FixFilePathCase tho.

[karthiknadig]

We could add ideOs as a field to the debug configuration. That should allow us to get rid of the debugOptions field. could you check if anything else is not covered already by the launch and attach configurations.

export enum DebugOptions {
    RedirectOutput = 'RedirectOutput',
    Django = 'Django',
    Jinja = 'Jinja',
    DebugStdLib = 'DebugStdLib',
    Sudo = 'Sudo',
    Pyramid = 'Pyramid',
    FixFilePathCase = 'FixFilePathCase',
    WindowsClient = 'WindowsClient',
    UnixClient = 'UnixClient',
    StopOnEntry = 'StopOnEntry',
    ShowReturnValue = 'ShowReturnValue',
    SubProcess = 'Multiprocess',
}

[fabioz]

The FixFilePathCase never had any functionality inside of pydevd.

I think it was used back in ptvsd so that if the user added a breakpoint in a file the debugger would make sure that filenames sent to the client that matched the normalized case of those files would change the file path to the same case sent by the client.

Currently we don't use it at all, so, it can be just removed (it's been a while since someone complained that the same file opens twice, which is probably what this fixed, so, I think that removing is ok).

[int19h]

Ah right, it was for the path mapping that the old wrapper was doing. So we don't need FixFilePathCase anymore.

It looks like Pyramid is some kind of leftover from the old debugger that we never actually supported since we moved to pydevd.

Everything else has a corresponding property already. So the only thing that's missing is ideOS. Can you file that as an issue?