Add validation going between JSON values/ PET and TS for Conda environments#1101
Closed
eleanorjboyd wants to merge 7 commits intomicrosoft:mainfrom
Closed
Add validation going between JSON values/ PET and TS for Conda environments#1101eleanorjboyd wants to merge 7 commits intomicrosoft:mainfrom
eleanorjboyd wants to merge 7 commits intomicrosoft:mainfrom
Conversation
- Added localized string 'dontShowAgain' in Common namespace - Modified TerminalEnvVarInjector to check persistent state before showing notification - Added showEnvFileNotification method with "Don't Show Again" button - Created comprehensive unit tests for the notification functionality Co-authored-by: eleanorjboyd <26030610+eleanorjboyd@users.noreply.github.com>
- Changed terminalEnvVarInjector to use windowApis.showInformationMessage - Updated tests to use proper mocking patterns - Fixed assert statements to use assert.ok() - Simplified test setup Tests are still being refined but implementation code is complete and working. Co-authored-by: eleanorjboyd <26030610+eleanorjboyd@users.noreply.github.com>
- Updated docstring to use "Don't Show Again" with proper capitalization - Verified test uses correct state key matching implementation - Code review and security checks passed Co-authored-by: eleanorjboyd <26030610+eleanorjboyd@users.noreply.github.com>
…PI and update related tests
…ure data integrity and improve error handling
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #1034