Add small timeout to avoid ctrl+c on Windows after activation

[anthonykim1]

Resolves: #640
I couldnt seem to repro ^C to show up on Python file run on Mac, but only on Windows.

This is happening because we have some extra polling happening before onCommandStarted event gets fired: https://github.com/microsoft/vscode/blob/86db4eb05dbfd82dc9b4ea022883494257ac3d63/src/vs/platform/terminal/common/capabilities/commandDetectionCapability.ts#L727 Which is what leads to resetting the value of promptInputModel:

We need the promptInputModel's value to be empty and state to be not execute in order to not cause ^C upon executeCommand run: https://github.com/microsoft/vscode/blob/86db4eb05dbfd82dc9b4ea022883494257ac3d63/src/vs/workbench/contrib/terminal/browser/terminalInstance.ts#L1010

So in that meantime before we clear the value of promptInput to empty string, the state will be execute and value of it will point to activation script. Which will lead to ^C.

I think we'd have better chance when we remove some Windows specific heuristics in command detection, after rolling out newer conpty as default.

[Tyriar]

A timeout like this will always be flaky unfortunately.

Have you considered awaiting the activate call if triggered via executeCommand, and queuing any further commands until that resolves?

[anthonykim1]

@Tyriar We actually do await for the activate call when activating with executeCommand

vscode-python-environments/src/features/pythonApi.ts

Lines 303 to 307 in 2693262

	const terminal = await this.terminalManager.getProjectTerminal(
	options.cwd instanceof Uri ? options.cwd : Uri.file(options.cwd),
	environment,
	);
	await runInTerminal(environment, terminal, options);

which goes to:

• vscode-python-environments/src/features/terminal/terminalActivationState.ts

  Line 118 in 2693262

  const promise = this.activateInternal(terminal, environment);

• then waiting

  vscode-python-environments/src/features/terminal/terminalActivationState.ts

  Line 183 in 2693262

  await this.activateUsingShellIntegration(terminal.shellIntegration, terminal, environment);

  for activated terminal
• Eventually

  vscode-python-environments/src/features/terminal/terminalActivationState.ts

  Lines 265 to 267 in 2693262

  	this.onTerminalShellExecutionEnd((e: TerminalShellExecutionEndEvent) => {
  	if (e.execution === execution) {
  	resolve();

  where we wait until onDidEndShellExecution is called

Maybe the better fix is to move where https://github.com/microsoft/vscode/blob/86db4eb05dbfd82dc9b4ea022883494257ac3d63/src/vs/platform/terminal/common/capabilities/commandDetection/promptInputModel.ts#L213 happens, to after execution in core?

[Tyriar]

Clearing the command when onCommandFinished fires makes sense (in addition to onCommandStart just in case?)