Skip to content

Comments

Implement sticky header for PR overview with tests#8528

Merged
mrleemurray merged 9 commits intomainfrom
mrleemurray/eldest-jade-magpie
Feb 17, 2026
Merged

Implement sticky header for PR overview with tests#8528
mrleemurray merged 9 commits intomainfrom
mrleemurray/eldest-jade-magpie

Conversation

@mrleemurray
Copy link
Contributor

@mrleemurray mrleemurray commented Feb 17, 2026

Add a sticky header to the pull request overview for improved navigation. Include tests to verify the header's visibility behavior.

sticky-header-ghpr.mp4

@mrleemurray mrleemurray self-assigned this Feb 17, 2026
@mrleemurray mrleemurray requested a review from alexr00 February 17, 2026 17:26
@mrleemurray mrleemurray added this to the February 2026 milestone Feb 17, 2026
@mrleemurray mrleemurray marked this pull request as ready for review February 17, 2026 17:26
Copilot AI review requested due to automatic review settings February 17, 2026 17:26
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds a sticky header to the pull request overview that appears when the user scrolls past the main title. The sticky header displays the PR status, title, number, and a copy link button, improving navigation when viewing long PR descriptions or timelines. The implementation uses IntersectionObserver to detect when the main title scrolls out of view and includes basic tests to verify the header's initial state.

Changes:

  • Added a useStickyHeader custom hook that uses IntersectionObserver to track title visibility
  • Implemented a StickyHeader component that displays PR status, title, number, and copy link button
  • Added CSS styling for the sticky header with smooth transitions and responsive design
  • Added test coverage to verify sticky header existence and initial visibility state

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File Description
webviews/editorWebview/overview.tsx Implements useStickyHeader hook and StickyHeader component with IntersectionObserver-based visibility tracking
webviews/editorWebview/index.css Adds comprehensive styling for sticky header including positioning, transitions, and responsive layout
webviews/editorWebview/test/overview.test.tsx Adds test assertions to verify sticky header exists and is not visible initially

mrleemurray and others added 2 commits February 17, 2026 17:32
Copilot AI review requested due to automatic review settings February 17, 2026 17:34
alexr00
alexr00 previously approved these changes Feb 17, 2026
Copy link
Member

@alexr00 alexr00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

Copy link
Contributor

Copilot AI commented Feb 17, 2026

@mrleemurray I've opened a new pull request, #8529, to work on those changes. Once the pull request is ready, I'll request review from you.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

Copilot AI review requested due to automatic review settings February 17, 2026 17:49
mrleemurray and others added 2 commits February 17, 2026 17:50
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.

@mrleemurray mrleemurray requested a review from alexr00 February 17, 2026 18:02
@mrleemurray mrleemurray merged commit 98e8b9a into main Feb 17, 2026
6 checks passed
@mrleemurray mrleemurray deleted the mrleemurray/eldest-jade-magpie branch February 17, 2026 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants