Skip to content

Comments

Switch over to multi-panel#8495

Merged
alexr00 merged 4 commits intomainfrom
alexr00/stiff-amphibian
Feb 9, 2026
Merged

Switch over to multi-panel#8495
alexr00 merged 4 commits intomainfrom
alexr00/stiff-amphibian

Conversation

@alexr00
Copy link
Member

@alexr00 alexr00 commented Feb 9, 2026

Fixes #3058

@alexr00 alexr00 self-assigned this Feb 9, 2026
@alexr00 alexr00 marked this pull request as ready for review February 9, 2026 18:06
Copilot AI review requested due to automatic review settings February 9, 2026 18:06
@alexr00 alexr00 enabled auto-merge (squash) February 9, 2026 18:06
@vs-code-engineering vs-code-engineering bot added this to the February 2026 milestone Feb 9, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses #3058 by changing the PR/issue overview webview implementation to support multiple concurrently open description panels instead of reusing a single shared panel.

Changes:

  • Replace single currentPanel tracking with a per-identity _panels: Map<string, Panel> keyed by owner/repo#number.
  • Update PR overview APIs (getCurrentPullRequest, getActivePanel, findPanel) to work with the multi-panel model.
  • Update PR overview tests to validate “reuse for same PR” and “separate panels for different PRs” behavior.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
src/github/issueOverview.ts Introduces panelKey and multi-panel tracking/lookup for issue/PR overview panels; updates dispose cleanup to remove from the map.
src/github/pullRequestOverview.ts Adapts PR overview to the shared multi-panel infrastructure and delegates active/lookup behavior to the base implementation.
src/test/github/pullRequestOverview.test.ts Updates test expectations and adds coverage for multiple PR panels coexisting.
Comments suppressed due to low confidence (1)

src/test/github/pullRequestOverview.test.ts:15

  • Unused import panelKey (not referenced anywhere in this test file). This will fail eslint @typescript-eslint/no-unused-vars; please remove it.
import { panelKey } from '../../github/issueOverview';
import { PullRequestModel } from '../../github/pullRequestModel';

@alexr00 alexr00 merged commit d89b169 into main Feb 9, 2026
12 checks passed
@alexr00 alexr00 deleted the alexr00/stiff-amphibian branch February 9, 2026 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow multiple PR description open at once

2 participants