Skip to content

Fix closed issue color in notifications view #8305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alexr00 merged 1 commit into from
Dec 12, 2025
+12 −2
Merged

Fix closed issue color in notifications view #8305

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3691,6 +3691,16 @@
},
"description": "The color used for indicating that an issue is closed."
},
{
"id": "github.issues.closed",
"defaults": {
"dark": "pullRequests.merged",
"light": "pullRequests.merged",
"highContrast": "editor.foreground",
"highContrastLight": "editor.foreground"
},
"description": "The color used for indicating that an issue is closed. Duplicates issues.closed because there's another extension that uses this identifier."
},
{
"id": "pullRequests.merged",
"defaults": {
Expand Down
2 changes: 1 addition & 1 deletion src/issues/issuesView.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ export class IssuesTreeData
treeItem.iconPath = (await DataUri.avatarCirclesAsImageDataUris(this.context, [avatarUser], 16, 16))[0] ??
(element.isOpen
? new vscode.ThemeIcon('issues', new vscode.ThemeColor('issues.open'))
: new vscode.ThemeIcon('issue-closed', new vscode.ThemeColor('issues.closed')));
: new vscode.ThemeIcon('issue-closed', new vscode.ThemeColor('github.issues.closed')));
} else {
// Use GitHub codicon when assignee setting is selected but no assignees exist
treeItem.iconPath = new vscode.ThemeIcon('github');
Expand Down
2 changes: 1 addition & 1 deletion src/notifications/notificationsManager.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@ export class NotificationsManager extends Disposable implements vscode.TreeDataP
if (notification.subject.type === NotificationSubjectType.Issue && model instanceof IssueModel) {
item.iconPath = element.model.isOpen
? new vscode.ThemeIcon('issues', new vscode.ThemeColor('issues.open'))
: new vscode.ThemeIcon('issue-closed', new vscode.ThemeColor('issues.closed'));
: new vscode.ThemeIcon('issue-closed', new vscode.ThemeColor('github.issues.closed'));
}
if (notification.subject.type === NotificationSubjectType.PullRequest && model instanceof PullRequestModel) {
item.iconPath = model.isOpen
Expand Down