Fix method call #8177
Merged
Fix method call #8177
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjbvz
approved these changes
Nov 20, 2025
Contributor
mjbvz
left a comment
mjbvz
left a comment
There was a problem hiding this comment.
Thanks! Good find. Surprised the signature of t doesn't catch this:
export function t(message: string, ...args: Array<string | number | boolean>): string;
Contributor
|
Oh it's because of the record overload :/ function t(message: string, args: Record<string, any>): string;I guess function's match |
mjbvz
added a commit
to mjbvz/vscode
that referenced
this pull request
Nov 20, 2025
We specify the allowed types for the `...rest` overload, but not for the record. Not sure why we didn't specify it in this case but it would have caught microsoft/vscode-pull-request-github#8177
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.