-
Notifications
You must be signed in to change notification settings - Fork 667
Use word dict for git branch naming #7933
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
@pwang347 👋 for PRs of code that you aren't the owner for you should add the owner as the reviewer since they will ultimately be the one to own the code in the future 🙂 Once you have dedicated ownership of something, then you can send PRs without reviewers which will land in our |
@TylerLeonhardt got it, thanks for the heads up! |
Note that the branch name needs to have the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me, thank you! I will indeed keep Alex for reivewing the dependency :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice change, just a few comments!
…vscode-pull-request-github into pawang/improveGitBranchNaming
…vscode-pull-request-github into pawang/improveGitBranchNaming
Fixes microsoft/vscode#264492