Skip to content

Conversation

pwang347
Copy link
Member

@pwang347 pwang347 commented Oct 3, 2025

@pwang347 pwang347 marked this pull request as ready for review October 3, 2025 23:35
@TylerLeonhardt
Copy link
Member

TylerLeonhardt commented Oct 3, 2025

@pwang347 👋 for PRs of code that you aren't the owner for you should add the owner as the reviewer since they will ultimately be the one to own the code in the future 🙂 Once you have dedicated ownership of something, then you can send PRs without reviewers which will land in our #codereview channel for anyone to review.

@TylerLeonhardt TylerLeonhardt requested a review from alexr00 October 3, 2025 23:45
@pwang347
Copy link
Member Author

pwang347 commented Oct 3, 2025

@TylerLeonhardt got it, thanks for the heads up!

@joshspicer joshspicer requested review from joshspicer and removed request for alexr00 October 3, 2025 23:49
@joshspicer
Copy link
Member

Note that the branch name needs to have the copilot/ prefix for reasons

@joshspicer joshspicer requested a review from alexr00 October 3, 2025 23:55
joshspicer
joshspicer previously approved these changes Oct 3, 2025
Copy link
Member

@joshspicer joshspicer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, thank you! I will indeed keep Alex for reivewing the dependency :)

Copy link
Member

@alexr00 alexr00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice change, just a few comments!

…vscode-pull-request-github into pawang/improveGitBranchNaming
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Coding Agent: UUID in branch name
4 participants