Skip to content

Conversation

@alexr00
Copy link
Member

@alexr00 alexr00 commented Oct 1, 2025

Fixes #7896

@alexr00 alexr00 enabled auto-merge (squash) October 1, 2025 08:24
@alexr00 alexr00 self-assigned this Oct 1, 2025
@vs-code-engineering vs-code-engineering bot added this to the September 2025 milestone Oct 1, 2025
@alexr00 alexr00 merged commit e317a8d into main Oct 1, 2025
6 checks passed
@alexr00 alexr00 deleted the alexr00/issue7896 branch October 1, 2025 09:18
@Wetmelon
Copy link

Wetmelon commented Oct 10, 2025

If I only open subfolders in a worktree, this no longer opens any pull requests associated with the checked-out branch, bricking the entire extension. Is there a setting I can use to disable this behavior? Will roll back to an older version as a workaround.

Think Monorepo with several out-of-tree git worktrees, and I only want to open a few subfolders of one of the worktrees to keep my workspace small.

EDIT: Confirmed that rolling back to older version restores the expected functionality👍

@alexr00
Copy link
Member Author

alexr00 commented Oct 13, 2025

@Wetmelon thanks for pointing this out. Maybe the behavior we need is to show repos that are within one of the workspace folders or contain one of the workspace folders.

@frontier159
Copy link

@alexr00 yeh I agree with @Wetmelon -- I frequently open a specific package sub-directly, which isn't the root.

Can it not just auto add the git rev-parse --show-toplevel directory into the list to show?

@frontier159
Copy link

Oh looks like it might be addressed in #8005?

@pWoLiAn
Copy link

pWoLiAn commented Nov 3, 2025

2025-11-03 08:55:35.569 [info] [Activation] Repo file:///root/vega/framework is not in a workspace folder, ignoring.

extension is ignoring valid submodules due to this change

@alexr00
Copy link
Member Author

alexr00 commented Nov 3, 2025

What is the value of your settings git.detectSubmodules and githubPullRequests.ignoreSubmodules?

@pWoLiAn
Copy link

pWoLiAn commented Nov 3, 2025

default values i.e. git.detectSubmodules=true and githubPullRequests.ignoreSubmodules=false

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Ignore worktrees that aren't in one of the workspace folders

6 participants