Checkout PR at the end of a completed chat session#7641
Merged
joshspicer merged 2 commits intomainfrom Aug 22, 2025
Merged
Conversation
Tyriar
approved these changes
Aug 22, 2025
alexr00
reviewed
Aug 25, 2025
Comment on lines
+665
to
+666
| const folderManager = reposManager.folderManagers[0]; | ||
| const pullRequest = await folderManager.fetchById(folderManager.gitHubRepositories[0], Number(prNumber)); |
Member
There was a problem hiding this comment.
This is not going to work for multi-repo. You can easily end up getting the wrong PR. In fully multi repo (usually multiroot workspace) setup, you could get a PR from an unrelated repo.
If there are multiple folder managers and github repos, it would be better to actually find the correct repo to fetch from. You can probably use getManagerForFile:
vscode-pull-request-github/src/github/repositoriesManager.ts
Lines 144 to 145 in aa02ca6
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes microsoft/vscode#260227