Fix review button disable logic with special handling for approve button

[Copilot]

This PR fixes an issue where clicking review buttons (Approve/Comment/Request Changes) without entering any text in the comment box and with no pending review comments would cause a GraphQL error and display duplicate entry boxes.

Problem

When users clicked review buttons with empty content, the extension would:

1. Create a new review
2. Attempt to submit it
3. Receive a GraphQL error because there were no review comments and no summary comment
4. Display duplicate comment entry boxes in a broken state

Solution

The fix implements differentiated disable logic for review buttons:

• Approve button: Always enabled (except when system is busy) - allows approval without additional comments
• Request Changes/Comment buttons: Disabled when both conditions are met:
  • The summary comment box is empty (or contains only whitespace) AND
  • There are no pending review comments (hasReviewDraft is false)

Changes Made

Updated all review submission components to apply the new disable logic:

AddReviewSummaryComment (timeline.tsx)

• Added state tracking for the textarea content (commentText)
• Approve button: Only disabled when isBusy || pr.busy
• Request Changes/Submit Review buttons: Disabled when !commentText.trim() && !pr.hasReviewDraft
• Made the textarea a controlled component with proper change handling

AddComment & AddCommentSimple (comment.tsx)

• Added hasReviewDraft to component props
• Implemented conditional disable logic based on current selection in ContextDropdown
• When Approve is selected: Dropdown only disabled when system is busy
• When other actions are selected: Dropdown disabled when !pendingCommentText?.trim() && !hasReviewDraft

Behavior

• ✅ Approve button is always enabled (except when system busy) - allows approval without comments
• ✅ Request Changes/Comment buttons enabled when user types text in comment field
• ✅ Request Changes/Comment buttons enabled when there are pending review comments (even with empty comment)
• ✅ Request Changes/Comment buttons disabled only when comment is empty AND no review comments exist
• ✅ Whitespace-only comments are treated as empty
• ✅ Consistent behavior across all review interfaces (timeline, overview, and comment components)

This prevents the GraphQL error and eliminates the duplicate entry box issue while maintaining GitHub's standard behavior where approvals don't require additional commentary.

Fixes #7476.

---

💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.

[alexr00]

@copilot The changes also need to be made in AddComment in comment.tsx

[Copilot]

@copilot The changes also need to be made in AddComment in comment.tsx

Applied the same disable logic to both AddComment and AddCommentSimple components in comment.tsx. The buttons will now be disabled when the comment text is empty AND there are no pending review comments, matching the behavior in timeline.tsx. (1a4045c)

Warning

Firewall rules blocked me from connecting to one or more addresses

I tried to connect to the following addresses, but was blocked by firewall rules:

• update.code.visualstudio.com
  • Triggering command: node ./out/src/test/runTests.js (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

• Configure Actions setup steps to set up my environment, which run before the firewall is enabled
• Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

[alexr00]

@copilot Actually, the approve button is allowed even when there are no comments and no pending review.

[Copilot]

@copilot Actually, the approve button is allowed even when there are no comments and no pending review.

Fixed! The approve button is now allowed even when there are no comments and no pending review. It's only disabled when the system is busy, while other review buttons (Request Changes, Comment/Submit Review) still require either content or existing review draft. (53fdb43)