Ensure re-request-review command is handled in activityBarViewProvider
#4540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshuaobrien
commented
Feb 19, 2023
| @@ -113,6 +115,18 @@ export class PullRequestViewProvider extends WebviewViewBase implements vscode.W | |||
| } | |||
| } | |||
|
|
|||
| private reRequestReview(message: IRequestMessage<string>): void { | |||
There was a problem hiding this comment.
Copied verbatim from
Would you like me to have a look at unifying any duplicated handlers?
There was a problem hiding this comment.
There's likely a lot of duplication between these two files. I'll take it as a debt item to clean them up.
alexr00
approved these changes
Feb 20, 2023
| @@ -113,6 +115,18 @@ export class PullRequestViewProvider extends WebviewViewBase implements vscode.W | |||
| } | |||
| } | |||
|
|
|||
| private reRequestReview(message: IRequestMessage<string>): void { | |||
There was a problem hiding this comment.
There's likely a lot of duplication between these two files. I'll take it as a debt item to clean them up.
chrmarti
approved these changes
Feb 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whilst working on #4539 I noticed that this command wasn't handled for this view. This change reveals a bit of layout shift after the user clicks the button. I'm happy to take a look at that this week :)
Before
old-click.mp4
After
new-click.mp4