Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support the copied permalink for Github Enterprise URL #3460

Merged

Conversation

hoontae24
Copy link
Contributor

@hoontae24 hoontae24 commented Apr 9, 2022

This PR is with respect to issue #3324

About Copying a Permalink:

  • The problem is copyGithubPermalink is always copying as a permalink based on github.com
  • If the remote upstream's fetch url is not based on "github.com", the copied permalink should be started upstream's url origin.
  • It helps using Github Enterprise Server.

Applied Conditions

  • You have to fill the Github Enterprise URI on VSCode config.(The attribute's name is github-enterprise.uri)

    • image
  • The Host of your git remote repository's upstream equals to the host of Github Enterprise URI

  • If the remote url is based on SSH, it checks equality of host(git@myenterprise.com => myenterprise.com) to the host of Github Enterprise URI

Let me know if there are any problems.

@ghost
Copy link

ghost commented Apr 9, 2022

CLA assistant check
All CLA requirements met.

@alexr00 alexr00 added this to the April 2022 milestone Apr 14, 2022
Copy link
Member

@alexr00 alexr00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants