[WIP] Changing the Pull Request node icon to represent merge-ability #1020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
RMacfarlane
reviewed
Mar 1, 2019
| @@ -376,13 +377,18 @@ export class PRNode extends TreeNode { | |||
| const tooltip = `${tooltipPrefix}${title} (#${formattedPRNumber}) by @${login}`; | |||
| const description = `#${formattedPRNumber} by @${login}`; | |||
|
|
|||
| const iconPath = { | |||
| light: mergeable ? 'resources/icons/light/check.svg' : 'resources/icons/delete.svg', | |||
There was a problem hiding this comment.
for these paths, I think we need to use a VSCode API to find the absolute path for them, since VSCode will know where the extension is installed
src/common/resources.ts has code for this, you can add the check and delete icons there and then import them here
There was a problem hiding this comment.
Thanks for the hints, I was going to have to ask that question eventually.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #681