Closed PRs get associated with new branches of the same name

[MetRonnie]

Sometimes, when I create a branch, I will find it becomes associated with a wrong PR that was previously closed and used the same branch name.

This can mean if you run the "delete local branches and remotes" command it will wrongly delete your branch.

• Extension version: 0.106.0
• VSCode Version: 1.98.0 (system setup)
• OS: Windows_NT x64 10.0.22631
• Repository Clone Configuration: fork of an upstream repository
• Github Product: Github.com

Steps to Reproduce:

Unknown. Note in .git/config you might see something like:

[branch "dev"]   # this branch was created a few days ago
	remote = origin
	merge = refs/heads/dev
	vscode-merge-base = origin/dev
	github-pr-owner-number = "cylc#cylc-ui#810"
	github-pr-owner-number = "cylc#cylc-ui#810"
	github-pr-owner-number = "cylc#cylc-ui#810"
	github-pr-owner-number = "cylc#cylc-ui#810"
	github-pr-owner-number = "cylc#cylc-ui#810"    # this is a PR that was closed 4 years ago!

or

[branch "log-wrap"]
	vscode-merge-base = origin/master
	remote = origin
	github-pr-owner-number = "cylc#cylc-ui#1708"
	github-pr-owner-number = "cylc#cylc-ui#1708"
	github-pr-owner-number = "cylc#cylc-ui#1708"
	github-pr-owner-number = "cylc#cylc-ui#1708"
	github-pr-owner-number = "cylc#cylc-ui#2078"   # finally the correct one!

[alexr00]

To verify:

• Create branch A
• Create a PR from A to main
• Close or merge the PR
• Push some commit(s) to branch A
• Create a new PR from A to main
• Run the "Delete local branches and remote" command.
• Verify that branch A is not deleted.

[MetRonnie]

Hi, I am still seeing this bug I'm afraid

• Extension version: 0.114.1
• VSCode version: 1.102.1

It looks like what happens is:

1. I create a new branch that happens to have the same name as a prior PR's branch
2. When I push that branch to a remote, the extension scans the repo's PRs and adds github-pr-owner-number = <prior> to the branch's entry in .git/config
3. I open a PR on github.com
4. The github-pr-owner-number does not get updated by the extension. However I have found the only way you can force it to update is by switching to a different commit then switching back to the branch.

However, I think the step 2 is causing a fundamental problem for the "delete local branches and remotes" command, because you can push a newly created branch and then run the command and it will be instantly deleted. IMO there should be a check that the head of the branch is at the same commit as the closed PR.