Could "Create a Pull Request" make fields within the create-pr view available faster?

[ulugbekna]

Screen.Recording.2023-10-25.at.16.45.16.mov

Version: 1.84.0-insider
Commit: 18b7f75a9fab40499744c2e9c6ba9af64d5c6744
Date: 2023-10-25T05:47:58.703Z
Electron: 25.9.2
ElectronBuildId: 24603566
Chromium: 114.0.5735.289
Node.js: 18.15.0
V8: 11.4.183.29-electron.0
OS: Darwin arm64 23.0.0

GHPR v0.75.2023102509

[karthiknadig]

It does appear faster for me.

[ulugbekna]

It seems faster than what AlexD reported but it's still slow. Wdyt if I re-open for the next milestone mabye, @alexr00 ?

Is the slowness inherent because the branch needs to be pushed first?

Screen.Recording.2023-10-25.at.19.08.08.mov

[alexr00]

The branch does not need to be pushed first (and isn't). The slowness is because we get the last commit so the title and description can be populated from the last commit message. We also fetch other things like the merge options, but it's getting the last commit details that is slowest. I can't speed that command up.

The only thing I can think to do here is try to always track the last commit, so that we already have the last commit message at the time that we create the view and don't need to ask git for it on demand. However, that would mean we're running the command unnecessarily often.

[alexr00]

@alexdima was hitting a recent regression, it should only be a second or so. @ulugbekna are you on version v0.75.2023102516 or newer?

[ulugbekna]

are you on version v0.75.2023102516 or newer?

Yes.

The only thing I can think to do here is try to always track the last commit, so that we already have the last commit message at the time that we create the view and don't need to ask git for it on demand. However, that would mean we're running the command unnecessarily often.

I find it sometimes useful that the last commit message is used as the PR name but more often need to change it as there are several commits. This becomes even more often with copilot support to generate PR info.

But also I'm surprised getting the last commit message is that expensive.

[alexr00]

It takes about 300 ms on my machine (and the view is quick, maybe about 1 second). If you share debug level logs I can see how slow it is on yours.

[ulugbekna]

I think it takes 3 seconds for me based on this gif:

Screen.Recording.2023-10-26.at.11.54.24.mov

2023-10-26 11:54:28.315 [debug] GitHubRepository> Fetch metadata - enter
2023-10-26 11:54:28.316 [debug] GitHubRepository> Fetch metadata microsoft/vscode - done
2023-10-26 11:54:28.316 [debug] GitHubRepository> Fetch metadata - enter
2023-10-26 11:54:28.316 [debug] GitHubRepository> Fetch metadata microsoft/vscode - done
2023-10-26 11:54:28.397 [debug] RateLimit> Extension rate limit remaining: 140, /repos/{owner}/{repo}/compare/{base}...{head}
2023-10-26 11:54:28.617 [debug] GitHubRepository> Fetch viewer permission - enter
2023-10-26 11:54:28.617 [debug] CreatePullRequestViewProvider> Compare branch name: main, Base branch name: main
2023-10-26 11:54:28.617 [debug] FolderRepositoryManager> Git tip message for branch main - enter
2023-10-26 11:54:28.617 [debug] CreatePullRequestViewProvider> Pull request template - enter
2023-10-26 11:54:28.617 [debug] RateLimit> Extension rate limit remaining: 139, GetViewerPermission
2023-10-26 11:54:28.617 [debug] GitHubRepository> Compare commits - enter
2023-10-26 11:54:28.617 [debug] RateLimit> Extension rate limit remaining: 138, /repos/{owner}/{repo}/compare/{base}...{head}
2023-10-26 11:54:28.918 [debug] RateLimit> REST Rate limit remaining: 4985, /repos/{owner}/{repo}/compare/{base}...{head}
2023-10-26 11:54:29.111 [debug] RateLimit> REST Rate limit remaining: 4984, /repos/{owner}/{repo}/compare/{base}...{head}
2023-10-26 11:54:29.111 [debug] GitHubRepository> Compare commits - done
2023-10-26 11:54:29.131 [debug] RateLimit> GraphQL Rate limit remaining: 4892, GetViewerPermission
2023-10-26 11:54:29.131 [debug] GitHubRepository> Fetch viewer permission - done
2023-10-26 11:54:29.173 [debug] FolderRepositoryManager> Git tip message for branch main - done
2023-10-26 11:54:31.952 [debug] CreatePullRequestViewProvider> Pull request template - done
2023-10-26 11:54:31.952 [debug] CreatePullRequestViewProvider> Total commits: 0
2023-10-26 11:54:31.952 [info] CreatePullRequestViewProvider> Initializing "create" view: {"defaultBaseRemote":{"owner":"microsoft","repositoryName":"vscode"},"defaultBaseBranch":"main","defaultCompareRemote":{"owner":"microsoft","repositoryName":"vscode"},"defaultCompareBranch":"main","defaultTitle":"Main","defaultDescription":"<!-- Thank you for submitting a Pull Request. Please:\n* Read our Pull Request guidelines:\n  https://github.com/microsoft/vscode/wiki/How-to-Contribute#pull-requests\n* Associate an issue with the Pull Request.\n* Ensure that the code is up-to-date with the `main` branch.\n* Include a description of the proposed changes and how to test them.\n-->\n","defaultMergeMethod":"squash","remoteCount":1,"allowAutoMerge":true,"mergeMethodsAvailability":{"merge":true,"squash":true,"rebase":true},"autoMergeDefault":false,"createError":"","labels":[],"isDraftDefault":false,"isDarkTheme":false,"generateTitleAndDescriptionTitle":"Generate with GitHub Copilot","creating":false}

---

I created a feature request for this to continue discussion there maybe - #5403