Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Respect git's pullBeforeCheckout setting for githubPullRequests.postCreate #4450

Closed
alexr00 opened this issue Jan 24, 2023 · 2 comments · Fixed by #4744
Closed

Respect git's pullBeforeCheckout setting for githubPullRequests.postCreate #4450

alexr00 opened this issue Jan 24, 2023 · 2 comments · Fixed by #4744
Assignees
@alexr00
Labels
feature-request Request for new features or functionality verification-needed Verification of issue is requested verified Verification succeeded
Milestone
April 2023

Comments

@alexr00
Copy link
Member

alexr00 commented Jan 24, 2023

Testing #4430

#4430 (comment)
@alexr00 alexr00 added the feature-request Request for new features or functionality label Jan 24, 2023
@alexr00 alexr00 added this to the February 2023 milestone Jan 24, 2023
@alexr00 alexr00 self-assigned this Jan 24, 2023
@alexr00
Copy link
Member Author

alexr00 commented Jan 24, 2023

@joaomoreno FYI

@alexr00 alexr00 modified the milestones: February 2023, March 2023 Feb 15, 2023
@kieferrm kieferrm mentioned this issue Mar 6, 2023
Closed
91 tasks
@alexr00 alexr00 modified the milestones: March 2023, April 2023 Mar 17, 2023
@alexr00 alexr00 mentioned this issue Mar 31, 2023
Closed
@kieferrm kieferrm mentioned this issue Apr 2, 2023
Closed
90 tasks
@alexr00
Copy link
Member Author

alexr00 commented Apr 19, 2023

I ended up respecting this git setting for all places where you checkout the default branch.

@alexr00 alexr00 mentioned this issue Apr 19, 2023
Merged
alexr00 added a commit that referenced this issue Apr 19, 2023
@alexr00
Respect git's pullBeforeCheckout setting for checking out default branch
251cce3 
Fixes #4450
alexr00 added a commit that referenced this issue Apr 19, 2023
@alexr00
Respect git's pullBeforeCheckout setting for checking out default bra…
a34f440 
…nch (#4744)

Fixes #4450
@alexr00 alexr00 added the verification-needed Verification of issue is requested label Apr 24, 2023
@rzhao271 rzhao271 added the verified Verification succeeded label Apr 26, 2023
@rzhao271 rzhao271 mentioned this issue Apr 26, 2023
Closed
rzhao271 added a commit to microsoft/vscode that referenced this issue Apr 26, 2023
@rzhao271
Do not merge
84122c9 
Ref microsoft/vscode-pull-request-github/issues/4450
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexr00 alexr00

Labels
feature-request Request for new features or functionality verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Milestone
April 2023
2 participants
@rzhao271 @alexr00