Can't resolve conversations from description page

[melink14]

• Extension version: v.0.26.0
• VSCode Version: 1.56.2
• OS: Windows_NT x64 10.0.19042

Steps to Reproduce:

1. Receive review comments on an open PR.
2. Create commit to resolve comments and push.
3. Go Pull Request description to close comment and see that it's marked Outdated with no option to resolve.

Resolving conversations in general was added in #2641 but I assume the interaction with Outdated commits is surfacing some thorns.

Of course, the work around is to resolve from GitHub website but my long term goal is to do everything from inside VS Code of course!

[alexr00]

Resolving a comment is not supported from the Description page. Instead, you need to go to the comment in the file that it's in and resolve it from there.

[BenjaVR]

@alexr00 is there any reason why this is not supported from the Description page? Would you consider supporting this?

[alexr00]

Yes, I'd consider it (I added it to the backlog because of this). It's just work that needs to be prioritized and done. A good way to let me know that there's interest in a feature request (and that I should consider prioritizing it) is to upvote it :).

[BenjaVR]

Great to know! I did not notice you adding it to the backlog 😄

Would you accept a PR for this? If you can point me in the right direction I can take a look at this.

[alexr00]

@BenjaVR I would like to take a PR for it, but I have just taken over managing this extension so my knowledge of what direction to point you in is low right now, but here's what I can tell you:

The comment section on the overview page is done here. I think you'd probably need to add to the action-bar.

vscode-pull-request-github/webviews/components/comment.tsx

Lines 61 to 86 in 09386e9

	<CommentBox
	for={comment}
	onMouseEnter={() => setShowActionBar(true)}
	onMouseLeave={() => setShowActionBar(false)}
	>
	{showActionBar ? (
	<div className="action-bar comment-actions">
	<button title="Quote reply" onClick={() => emitter.emit('quoteReply', bodyMd)}>
	{commentIcon}
	</button>
	{canEdit ? (
	<button title="Edit comment" onClick={() => setEditMode(true)}>
	{editIcon}
	</button>
	) : null}
	{canDelete ? (
	<button title="Delete comment" onClick={() => deleteComment({ id, pullRequestReviewId })}>
	{deleteIcon}
	</button>
	) : null}
	</div>
	) : null}
	<CommentBody comment={comment as IComment} bodyHTML={bodyHTMLState} body={bodyMd} />
	</CommentBox>
	);
	}

Here is how you delete a comment, which you can use as reference for resolving a comment.

vscode-pull-request-github/webviews/common/context.tsx

Lines 72 to 97 in 9346269

	public deleteComment = async (args: { id: number; pullRequestReviewId?: number }) => {
	await this.postMessage({ command: 'pr.delete-comment', args });
	const { pr } = this;
	const { id, pullRequestReviewId } = args;
	if (!pullRequestReviewId) {
	this.updatePR({
	events: pr.events.filter(e => e.id !== id),
	});
	return;
	}
	const index = pr.events.findIndex(e => e.id === pullRequestReviewId);
	if (index === -1) {
	console.error('Could not find review:', pullRequestReviewId);
	return;
	}
	const review: ReviewEvent = pr.events[index] as ReviewEvent;
	if (!review.comments) {
	console.error('No comments to delete for review:', pullRequestReviewId, review);
	return;
	}
	this.pr.events.splice(index, 1, {
	...review,
	comments: review.comments.filter(c => c.id !== id),
	});
	this.updatePR(this.pr);
	};

Once you have the appropriate args, you can use this to resolve:

vscode-pull-request-github/src/commentHandlerResolver.ts

Lines 22 to 23 in 4c6d79c

	resolveReviewThread(thread: GHPRCommentThread, input?: string): Promise<void>;
	unresolveReviewThread(thread: GHPRCommentThread, input?: string): Promise<void>;

which I expect you would call from a new entry in this switch statement:

vscode-pull-request-github/src/github/issueOverview.ts

Lines 187 to 188 in cda4dd3

	switch (message.command) {
	case 'alert':

[samgermain]

Would also like this feature

[alexr00]

duplicate of #2685