Skip to content
This repository was archived by the owner on Apr 19, 2024. It is now read-only.

Enable a mechanism for something to inject data into vscode-nls - #42

Merged
Tyler James Leonhardt (TylerLeonhardt) merged 8 commits into
mainfrom
tyler/sample-release
Aug 8, 2022
Merged

Enable a mechanism for something to inject data into vscode-nls#42
Tyler James Leonhardt (TylerLeonhardt) merged 8 commits into
mainfrom
tyler/sample-release

Conversation

@TylerLeonhardt

Copy link
Copy Markdown
Member

This will be used by VS Code to inject the message bundle into the vscode-nls instance imported by a specific extension.

VS Code has a concept of a RequireInterceptor and will return the real strings from the bundle instead of the default value of nothing which is seen in this PR.

@dbaeumer Dirk Bäumer (dbaeumer) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM.

Comment thread src/browser/main.ts
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants