-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: usage of deprecated
version of Node.js
#309
Merged
karthiknadig
merged 2 commits into
microsoft:main
from
hamirmahal:fix/usage-of-action-that-uses-deprecated-version-of-nodejs
Jul 30, 2024
Merged
fix: usage of deprecated
version of Node.js
#309
karthiknadig
merged 2 commits into
microsoft:main
from
hamirmahal:fix/usage-of-action-that-uses-deprecated-version-of-nodejs
Jul 30, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* tmp * Upgrade to 1.10.1 * Generate with py3.8 --------- Co-authored-by: Megh Parikh <mparikh27@bloomberg.net>
hamirmahal
commented
Jul 2, 2024
@@ -38,7 +38,7 @@ jobs: | |||
|
|||
steps: | |||
- name: Checkout repository | |||
uses: actions/checkout@v3 | |||
uses: actions/checkout@v4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the latest major version as of the time of this writing.
Out of curiosity, what are your thoughts on setting up CodeQL checks via the repository settings, as opposed to through a workflow file? |
karthiknadig
approved these changes
Jul 29, 2024
eleanorjboyd
approved these changes
Jul 30, 2024
hamirmahal
deleted the
fix/usage-of-action-that-uses-deprecated-version-of-nodejs
branch
July 30, 2024 03:15
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #308.