Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Mypy settings descriptions #218

Merged
merged 2 commits into from
Nov 13, 2023
Merged

Conversation

luabud
Copy link
Member

@luabud luabud commented Nov 10, 2023

No description provided.

@luabud luabud added documentation Improvements or additions to documentation debt Technical debt or repo cleanup labels Nov 10, 2023
@luabud luabud marked this pull request as ready for review November 10, 2023 20:43
karthiknadig
karthiknadig previously approved these changes Nov 10, 2023
package.nls.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
Co-authored-by: Karthik Nadig <kanadig@microsoft.com>
Copy link
Member

@cwebster-99 cwebster-99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@karthiknadig karthiknadig merged commit 9640da1 into microsoft:main Nov 13, 2023
20 checks passed
karthiknadig added a commit to karthiknadig/vscode-mypy that referenced this pull request Nov 13, 2023
* Update Mypy settings descriptions

* Apply suggestions from code review

Co-authored-by: Karthik Nadig <kanadig@microsoft.com>

---------

Co-authored-by: Karthik Nadig <kanadig@microsoft.com>
karthiknadig added a commit that referenced this pull request Nov 13, 2023
* Update Mypy settings descriptions

* Apply suggestions from code review

Co-authored-by: Karthik Nadig <kanadig@microsoft.com>

---------

Co-authored-by: Karthik Nadig <kanadig@microsoft.com>
@karthiknadig
Copy link
Member

@luabud you are making changes after merge. It wont get applied.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
debt Technical debt or repo cleanup documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants