Skip to content

Conversation

@lewis-sanchez
Copy link
Contributor

@lewis-sanchez lewis-sanchez commented Dec 12, 2025

Pull Request Template – vscode-mssql

Description

This PR addresses the code review comments that were left in this PR: #20750

Provide a clear, concise summary of the changes in this PR. What problem does it solve? Why is it needed? Link any related issues using issue closing keywords.

Code Changes Checklist

  • New or updated unit tests added
  • All existing tests pass (npm run test)
  • Code follows contributing guidelines
  • Telemetry/logging updated if relevant
  • No regressions or UX breakage

Reviewers: Please read our reviewer guidelines

@github-actions
Copy link

PR Changes

Category Target Branch PR Branch Difference
vscode-mssql VSIX 5283 KB 5283 KB ⚪ 0 KB ( 0% )
sql-database-projects VSIX 5668 KB 5668 KB ⚪ 0 KB ( 0% )

@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 65.90%. Comparing base (059b9b9) to head (24c6846).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #20802      +/-   ##
==========================================
- Coverage   65.90%   65.90%   -0.01%     
==========================================
  Files         210      210              
  Lines       19989    19989              
  Branches     2596     2596              
==========================================
- Hits        13174    13173       -1     
  Misses       6718     6718              
- Partials       97       98       +1     

see 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants