Add configuration option to show batch start/completion messages (default enabled) #20751
+38
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamhartford
requested review from
Benjin,
aasimkhan30,
allancascante,
caohai,
kburtram,
laurenastrid1,
lewis-sanchez,
manujoseph85 and
ssreerama
as code owners
Author
|
@microsoft-github-policy-service agree |
Benjin
reviewed
Dec 11, 2025
| ); | ||
| resultWebviewState.messages.push(message); | ||
| this.scheduleThrottledUpdate(queryRunner.uri); | ||
| let showBatchMessages: boolean = extConfig.get(Constants.configShowBatchMessages) ?? true; |
Contributor
There was a problem hiding this comment.
default value in the config definition should handle the ?? true case already
Benjin
reviewed
Dec 11, 2025
| this.scheduleThrottledUpdate(queryRunner.uri); | ||
| let showBatchMessages: boolean = extConfig.get(Constants.configShowBatchMessages) ?? true; | ||
|
|
||
| if (showBatchMessages) { |
Contributor
There was a problem hiding this comment.
since checking this flag would be an early bail-out, it'd be a bit cleaner to do
if (showBatchMesssages === false) {
return;
}
and leave the rest untouched
Contributor
Contributor
|
@adamhartford looks like the test build is failing due to linter errors; can you clean those up? Should be able to just run the vscode formatter. |
Author
|
@Benjin Thanks for the feedback. I've made the changes you suggested and fixed the linter errors. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new configuration option
mssql.showBatchMessagesthat allows users to control the display of batch start and completion messages in the SQL output panel.Problem: When executing large SQL files (thousands of lines), the output panel becomes cluttered with "Started executing query at..." and "Commands completed successfully" messages, making it difficult to spot actual error messages. This differs from SQL Server Management Studio behavior, which doesn't show these verbose batch messages by default.
Solution: Added a configurable option that:
true(preserves current behavior for backward compatibility)false, suppresses batch start/completion messages while preserving all error messages