Skip to content

Conversation

@laurenastrid1
Copy link
Contributor

Pull Request Template – vscode-mssql

Description

Fixes #20579
Fixes #19606

Check whether a connection is a docker container by matching a connections' server info's machine name to the existing docker container ids.

Also fixes #20536 by properly escaping container inputs on container creation

serverInfoCheckContainer
serverInfoCheckNonContainer

Code Changes Checklist

  • New or updated unit tests added
  • All existing tests pass (npm run test)
  • Code follows contributing guidelines
  • Telemetry/logging updated if relevant
  • No regressions or UX breakage

Reviewers: Please read our reviewer guidelines

@github-actions
Copy link

github-actions bot commented Dec 3, 2025

PR Changes

Category Target Branch PR Branch Difference
vscode-mssql VSIX 5271 KB 5258 KB ⚪ -13 KB ( 0% )
sql-database-projects VSIX 5668 KB 5668 KB ⚪ 0 KB ( 0% )

@codecov-commenter
Copy link

codecov-commenter commented Dec 3, 2025

Codecov Report

❌ Patch coverage is 50.00000% with 20 lines in your changes missing coverage. Please review.
✅ Project coverage is 65.50%. Comparing base (775556e) to head (688441f).
⚠️ Report is 21 commits behind head on main.

Files with missing lines Patch % Lines
...s/mssql/src/objectExplorer/nodes/connectionNode.ts 44.44% 10 Missing ⚠️
...ensions/mssql/src/controllers/connectionManager.ts 30.76% 9 Missing ⚠️
.../mssql/src/objectExplorer/objectExplorerService.ts 80.00% 1 Missing ⚠️

❌ Your patch status has failed because the patch coverage (50.00%) is below the target coverage (70.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #20728      +/-   ##
==========================================
- Coverage   65.55%   65.50%   -0.06%     
==========================================
  Files         210      210              
  Lines       19508    19514       +6     
  Branches     2482     2480       -2     
==========================================
- Hits        12789    12782       -7     
- Misses       6633     6646      +13     
  Partials       86       86              
Files with missing lines Coverage Δ
extensions/mssql/src/constants/constants.ts 100.00% <ø> (ø)
extensions/mssql/src/deployment/dockerUtils.ts 93.62% <100.00%> (+0.31%) ⬆️
.../mssql/src/objectExplorer/objectExplorerService.ts 71.15% <80.00%> (+0.26%) ⬆️
...ensions/mssql/src/controllers/connectionManager.ts 52.66% <30.76%> (-0.39%) ⬇️
...s/mssql/src/objectExplorer/nodes/connectionNode.ts 78.03% <44.44%> (-3.94%) ⬇️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Benjin
Copy link
Contributor

Benjin commented Dec 6, 2025

What's the overall logic for determining whether a connection is a local docker image or a different local instance (e.g. an xcopy or LOCALDB instance)? Can you add that as a comment somewhere?

@laurenastrid1
Copy link
Contributor Author

What's the overall logic for determining whether a connection is a local docker image or a different local instance (e.g. an xcopy or LOCALDB instance)? Can you add that as a comment somewhere?

once a connection is made, figure out the machine name the connection is hosted on documented in the connection's server info; on docker connections, the machine name is the UUID corresponding to the container's id.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

5 participants