-
Notifications
You must be signed in to change notification settings - Fork 556
Identify whether a connection is a docker container in OE #20728
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
PR Changes
|
Codecov Report❌ Patch coverage is ❌ Your patch status has failed because the patch coverage (50.00%) is below the target coverage (70.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #20728 +/- ##
==========================================
- Coverage 65.55% 65.50% -0.06%
==========================================
Files 210 210
Lines 19508 19514 +6
Branches 2482 2480 -2
==========================================
- Hits 12789 12782 -7
- Misses 6633 6646 +13
Partials 86 86
🚀 New features to boost your workflow:
|
|
What's the overall logic for determining whether a connection is a local docker image or a different local instance (e.g. an xcopy or LOCALDB instance)? Can you add that as a comment somewhere? |
once a connection is made, figure out the machine name the connection is hosted on documented in the connection's server info; on docker connections, the machine name is the UUID corresponding to the container's id. |
Pull Request Template – vscode-mssql
Description
Fixes #20579
Fixes #19606
Check whether a connection is a docker container by matching a connections' server info's machine name to the existing docker container ids.
Also fixes #20536 by properly escaping container inputs on container creation
Code Changes Checklist
npm run test)Reviewers: Please read our reviewer guidelines