-
Notifications
You must be signed in to change notification settings - Fork 534
Publish Dialog - Adding Target field functionality #20217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: sai/vscodePublishDialog
Are you sure you want to change the base?
Publish Dialog - Adding Target field functionality #20217
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This pull request adds SQL Server container publishing functionality to the vscode-mssql extension. The changes enable users to deploy SQL databases to local development containers by introducing new form fields, validation logic, and Docker integration utilities.
Key changes include:
- Added container-specific form fields (port, admin password, image tag, license acceptance) with validation
- Implemented Docker image tag fetching and selection based on project target version
- Extended the publish dialog state and form interfaces to support container deployment options
Reviewed Changes
Copilot reviewed 16 out of 16 changed files in this pull request and generated 4 comments.
Show a summary per file
File | Description |
---|---|
test/unit/publishProjectDialog.test.ts | New test file for publish dialog functionality |
src/sharedInterfaces/publishDialog.ts | Extended interfaces with container fields and project properties |
src/reactviews/pages/PublishProject/types.ts | New type definitions for publish form context |
src/reactviews/pages/PublishProject/publishProject.tsx | Updated main dialog with validation and script generation logic |
src/reactviews/pages/PublishProject/components/PublishTargetSection.tsx | Enhanced target section with container field rendering |
src/reactviews/pages/PublishProject/components/PublishProfileSection.tsx | Refactored to use shared type definitions |
src/reactviews/pages/PublishProject/components/ConnectionSection.tsx | Updated to use shared type definitions |
src/publishProject/publishProjectWebViewController.ts | Enhanced controller with Docker integration and immutable state updates |
src/publishProject/projectUtils.ts | New utility functions for project properties and form validation |
src/publishProject/formComponentHelpers.ts | Added container-specific form components with validation |
src/publishProject/dockerUtils.ts | New Docker utilities for image selection and validation |
src/controllers/mainController.ts | Updated to pass SQL projects service to publish controller |
src/constants/locConstants.ts | Added localization strings for container publishing |
src/constants/constants.ts | Added Docker-related constants and publish target types |
localization/xliff/vscode-mssql.xlf | Updated localization file with new strings |
localization/l10n/bundle.l10n.json | Updated localization bundle with new strings |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Pull Request Template – vscode-mssql
Description
This pull request adds support for SQL Server container publishing by introducing new constants, localization strings, validation logic, and utility functions. The changes primarily focus on enabling configuration and validation of SQL Server container deployment options in the publishing workflow.
Localization and User Messaging:
localization/l10n/bundle.l10n.json
,localization/xliff/vscode-mssql.xlf
). [1] [2] [3] [4] [5] [6] [7] [8]Constants and Configuration:
src/constants/constants.ts
.Validation and Utility Logic:
src/publishProject/dockerUtils.ts
.Form Component and Messaging Integration:
src/constants/locConstants.ts
to expose new localized messages and validation functions for use in publish dialogs.src/publishProject/formComponentHelpers.ts
to import and use the new validation logic for form components.Controller Integration:
sqlProjectsService
to the publish project webview controller for extended functionality in SQL Server container publishing (src/controllers/mainController.ts
).** New Files for the target section**
Code Changes Checklist
npm run test
)Reviewers: Please read our reviewer guidelines