-
Notifications
You must be signed in to change notification settings - Fork 535
Removing the legacy connection management flow #19887
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please make sure we are not leaving legacy stuff in package.json
"mssql.useLegacyQueryResultExperience": true, | ||
"mssql.useLegacyConnectionExperience": true, | ||
"mssql.autoDisableNonTSqlLanguageService": false | ||
"mssql.autoDisableNonTSqlLanguageService": false, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove
@Benjin, I have fixed the smoke tests. Can you please remove legacy conn management? |
Pull Request Template – vscode-mssql
Description
Removing the legacy connection management flow (prompt-based creation and editing)
Code Changes Checklist
npm run test
)Reviewers: Please read our reviewer guidelines