Skip to content

Conversation

Benjin
Copy link
Contributor

@Benjin Benjin commented Aug 6, 2025

Pull Request Template – vscode-mssql

Description

Removing the legacy connection management flow (prompt-based creation and editing)

Code Changes Checklist

  • New or updated unit tests added
  • All existing tests pass (npm run test)
  • Code follows contributing guidelines
  • Telemetry/logging updated if relevant
  • No regressions or UX breakage

Reviewers: Please read our reviewer guidelines

aasimkhan30
aasimkhan30 previously approved these changes Aug 6, 2025
Copy link
Contributor

@aasimkhan30 aasimkhan30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make sure we are not leaving legacy stuff in package.json

"mssql.useLegacyQueryResultExperience": true,
"mssql.useLegacyConnectionExperience": true,
"mssql.autoDisableNonTSqlLanguageService": false
"mssql.autoDisableNonTSqlLanguageService": false,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove

@aasimkhan30
Copy link
Contributor

@Benjin, I have fixed the smoke tests. Can you please remove legacy conn management?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants