Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix client capabilities in window/progress proposed doc #481

Closed
wants to merge 1 commit into from

Conversation

Xanewok
Copy link
Contributor

@Xanewok Xanewok commented Apr 14, 2019

Fixes wrong ClientCapabilities extension from #261.

@dbaeumer by the way, what is the workflow for proposed features? Do they become a part of a regular protocol version but noted that they're unstable and only proposed at the moment?

@dbaeumer
Copy link
Member

@Xanewok thanks. I already started fixing this on the correspoding progress branch I have.

While implementing cancel support I separated the notification into start, report, done and cancel. Mainly because it was very hard to descibe in which cases which property combinations were valid. Was a lot easier having separate literals per request. I hope this is OK with you.

For going forward with the proposal: I added a comment here microsoft/language-server-protocol#70 (comment) to get additional feedback on the proposal. If there is no strong objection I usually merge the proposal into the final version.

I will also publish new next version of the node libraries containing the implementation.

@dbaeumer dbaeumer closed this Apr 15, 2019
@Xanewok Xanewok deleted the window-progress branch April 21, 2019 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants