Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

try delegating even if we cannot get the full info #16057

Merged
merged 2 commits into from
Sep 17, 2024
Merged

Conversation

amunger
Copy link
Contributor

@amunger amunger commented Sep 17, 2024

Fixes #16026

We add the context menu command only if we decide that the variable can support a Data viewer, so it seems pretty safe to try and delegate the Data viewer command out even if we can't get the type info at that moment.

@pwang347
Copy link
Member

Hi @amunger, thanks for looking into this!
Do you know if this fixes microsoft/vscode-data-wrangler#285 as well?

@amunger
Copy link
Contributor Author

amunger commented Sep 17, 2024

@pwang347 - It will now call the DW command in that case, where it didn't before, but DW fails to open the viewer with Could not retrieve variable <MyEnum.ONE: 1> from the Jupyter extension. Please file an issue on the Data Wrangler GitHub repository.

info we are passing:
{"name":"<MyEnum.ONE: 1>","count":0,"shape":"","size":0,"supportsDataExplorer":false,"value":"...","truncated":true,"frameId":9}

for some reason, the name from the context does not include the parent variable d on that variable, which may be an issue with debugpy

@amunger amunger marked this pull request as ready for review September 17, 2024 20:52
@amunger amunger enabled auto-merge (squash) September 17, 2024 20:52
@vs-code-engineering vs-code-engineering bot added this to the September 2024 milestone Sep 17, 2024
@amunger amunger merged commit 32f816c into main Sep 17, 2024
26 of 27 checks passed
@amunger amunger deleted the aamunger/DWDelegation branch September 17, 2024 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Data Wrangler (often) doesn't get called when trying to open a DataFrame from other frames on the call stack
3 participants