Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

migrate and organize Interactive window settings #12810

Merged
merged 6 commits into from
Feb 10, 2023
Merged

migrate and organize Interactive window settings #12810

merged 6 commits into from
Feb 10, 2023

Conversation

amunger
Copy link
Contributor

@amunger amunger commented Feb 10, 2023 •
edited
Loading

Fixes #12393

  • Changed the configuration keys for IW settings, putting them in the Interactive Window section
  • migrate the old setting names to the more descriptive ones, keeping the same scope.
  • Still check the old setting name when retrieving settings since the migration is asynchronous, and reading a setting value is not

@amunger amunger marked this pull request as ready for review February 10, 2023 20:03
@amunger amunger merged commit caffc57 into main Feb 10, 2023
@amunger amunger deleted the aamunger/configurations branch February 10, 2023 20:12
This was referenced Nov 23, 2023
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lramos15 lramos15 lramos15 approved these changes

Assignees

@amunger amunger

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Interactive Window settings are hard to identify
2 participants
@amunger @lramos15