Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

title run menu contribution to run file in IW #12617

Merged
merged 1 commit into from
Jan 23, 2023
Merged

Conversation

amunger
Copy link
Contributor

@amunger amunger commented Jan 23, 2023

Fixes #7683

add a launch contribution to run a python file in the interactive window.

The title should be changed to match up with Python's wording better, but the title only seems to be pulled from where the command is contributed, not the specific menu item contribution.

@amunger amunger requested a review from roblourens January 23, 2023 21:36
@amunger
Copy link
Contributor Author

amunger commented Jan 23, 2023

image

@vscodenpa vscodenpa added this to the January 2023 milestone Jan 23, 2023
{
"command": "jupyter.runFileInteractive",
"group": "jupyter",
"when": "resourceLangId == python && !isInDiffEditor && !notebookEditorFocused && isWorkspaceTrusted"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So this can work for any python file, even if it doesn't have #%%?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And is there a debug option?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

correct, cells are not required.
No current debug option - debugFileInteractive has very low usage relative to runFile or debugCell, though perhaps there is an argument for discoverability to be made.

@amunger amunger merged commit cbe8b26 into main Jan 23, 2023
@amunger amunger deleted the aamunger/launchIW branch January 23, 2023 22:12
@amunger amunger added interactive-window Impacts interactive window feature-request Request for new features or functionality and removed interactive-window Impacts interactive window feature-request Request for new features or functionality labels Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add dropdown contribution to file editor Run icon for Run file in Interactive window
3 participants