Merge loader and registration interfaces #12477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DonJayamanne
commented
Jan 3, 2023
| public get loaded() { | ||
| return this.controllersPromise; | ||
| } | ||
| private async onDidOpenNotebookDocument(document: NotebookDocument) { |
There was a problem hiding this comment.
Brought all of this from another class.
Most of the code is very closely related, hence merged into a single class for easier maintenance
Besides a lot of this code will get deleted once we ship the new kernel picker.
aeschli
approved these changes
Jan 9, 2023
DonJayamanne
added a commit
that referenced
this pull request
Jan 11, 2023
* main: (139 commits) Support Protocols in WS for custom Jupyter Servers (#12513) move IW run commands to submenu (#12533) return undefined when no folding regions to return (#12527) Remove markdown styles and move to renderer ext (#12468) Stop storing interpreter info in ipynb file (#12523) Remove details from all sources in kernel picker (#12525) Stop using preferred kernel service with MRU (#12522) Display kernelSpec src only if kernels are found (#12517) Update kernel source label (#12516) Auto select remote server Uri entry input item (#12479) Remove duplicate info in kernel quick pick (#12515) Fix settings scope (#12457) Disable ISort on CI (#12509) Merge loader and registration interfaces (#12477) Skip broken LSP tests (#12504) Bump version to ensure latest insiders goes out (#12505) Ignore spurious output when testing imports (#12495) Deprecated setting jupyterCommandLineArguments (#12466) Bump flat from 4.1.1 to 5.0.1 (#12472) Intercept debugpyAttach message to avoid error (#12498) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #11648