Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go to cell code lens fixes #11460

Merged
merged 2 commits into from
Sep 26, 2022
Merged

go to cell code lens fixes #11460

merged 2 commits into from
Sep 26, 2022

Conversation

amunger
Copy link
Contributor

@amunger amunger commented Sep 26, 2022

Fixes #11458
Fixes #7687

@codecov-commenter
Copy link

Codecov Report

Merging #11460 (d616358) into main (2fe0075) will decrease coverage by 0%.
The diff coverage is 0%.

@@          Coverage Diff           @@
##            main   #11460   +/-   ##
======================================
- Coverage     63%      63%   -1%     
======================================
  Files        477      477           
  Lines      34168    34166    -2     
  Branches    5546     5546           
======================================
- Hits       21615    21613    -2     
- Misses     10497    10499    +2     
+ Partials    2056     2054    -2     
Impacted Files Coverage Δ
src/interactive-window/interactiveWindow.ts 75% <0%> (+<1%) ⬆️
.../notebooks/controllers/controllerDefaultService.ts 65% <0%> (-9%) ⬇️
src/kernels/execution/notebookUpdater.ts 88% <0%> (-8%) ⬇️
...andalone/intellisense/intellisenseProvider.node.ts 79% <0%> (-2%) ⬇️
src/standalone/api/kernelApi.ts 75% <0%> (-2%) ⬇️
...c/platform/common/process/pythonDaemonPool.node.ts 76% <0%> (-1%) ⬇️
...otebooks/controllers/controllerPreferredService.ts 85% <0%> (-1%) ⬇️
src/platform/common/utils/decorators.ts 90% <0%> (-1%) ⬇️
...kernels/jupyter/launcher/jupyterConnection.node.ts 84% <0%> (-1%) ⬇️
src/kernels/raw/launcher/kernelProcess.node.ts 72% <0%> (-1%) ⬇️
... and 8 more

@amunger amunger merged commit 712c7c0 into main Sep 26, 2022
@amunger amunger deleted the aamunger/gotoCellCodeLens branch September 26, 2022 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

go to cell code lens for Interactive Window has no effect Go to cell highlight is a bit weird
3 participants