Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added release plan item to handle test failures #11151

Merged
merged 1 commit into from
Aug 18, 2022
Merged

Conversation

amunger
Copy link
Contributor

@amunger amunger commented Aug 18, 2022

Fixes #10634

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR).
  • Title summarizes what is changing.
  • Has a news entry file (remember to thank yourself!).
  • Appropriate comments and documentation strings in the code.
  • Has sufficient logging.
  • Has telemetry for feature-requests.
  • Unit tests & system/integration tests are added/updated.
  • Test plan is updated as appropriate.
  • package-lock.json has been regenerated by running npm install (if dependencies have changed).

@amunger amunger requested a review from a team as a code owner August 18, 2022 15:18
Copy link
Member

@IanMatthewHuff IanMatthewHuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, I like this change. Release champ should not have to fix it all with area ownership (ok to assign others to investigate), but I want to be all green in the release branch when porting late fixes.

@amunger amunger merged commit bc5b95c into main Aug 18, 2022
@amunger amunger deleted the aamunger/releasePlan branch August 18, 2022 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dealing with CI / Test Failures / Flakey Tests
2 participants