Only show the "restart required" message if kernels are actually active after installing python extension #10829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IanMatthewHuff
commented
Jul 15, 2022
| // This class is responsible for watching if the Python Extension installation status changes, and if it does | ||
| // update the users if any notebooks are running and need to be restarted. | ||
| @injectable() | ||
| export class PythonExtensionRestartNotification implements IExtensionSyncActivationService { |
There was a problem hiding this comment.
Since the checker is in platform and our workflow here involved being able to look at kernels added the event to the checker to indicate installation and a new standalone service to look at the kernels and surface the message as needed.
IanMatthewHuff
commented
Jul 15, 2022
| }); | ||
|
|
||
| // Create an instance of the restart notification with the stubbed checker | ||
| const notifier = createService(api.serviceContainer); |
There was a problem hiding this comment.
Test was a little bit hard to write, since I didn't want to actually install / uninstall python. Poked around at a few of Don's bag of tricks and I think this works. Stub out the extension installed event from the checker, create a new instance of the class (which picks up the stubbed event), and see if that notifies or not.
rchiodo
approved these changes
Jul 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10697
package-lock.jsonhas been regenerated by runningnpm install(if dependencies have changed).