Fix problems with context keys and strings for remote connections #10768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #10768 +/- ##
======================================
Coverage 63% 63%
======================================
Files 476 476
Lines 33039 33048 +9
Branches 5384 5387 +3
======================================
+ Hits 20828 20840 +12
+ Misses 10201 10200 -1
+ Partials 2010 2008 -2
|
|
@DonJayamanne @amunger @IanMatthewHuff @sadasant can somebody take a look? Thanks. |
amunger
approved these changes
Jul 12, 2022
| @@ -780,7 +780,7 @@ | |||
| "comment": ["{Locked='python -m jupyter notebook --version'}"] | |||
| }, | |||
| "DataScience.savePngTitle": "Save Image", | |||
| "DataScience.jupyterSelectURIQuickPickTitle": "Pick how to connect to Jupyter", | |||
| "DataScience.jupyterSelectURIQuickPickTitle": "Enter the URI of the running Jupyter server", | |||
There was a problem hiding this comment.
Isn't there a localize.ts entry as well?
There was a problem hiding this comment.
The bug here was that this file didn't have the new text. the localize.ts file alredy says 'Enter the URI of the running Jupyter server'.
On web we use the nls.json file. On desktop the localize.ts file is translated by the translation files.
There was a problem hiding this comment.
@rchiodo Ahh should have paid more attention to the bug. I just saw one file and not the other. Sounds good.
IanMatthewHuff
approved these changes
Jul 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10672
Also fixes some problems with the 'back' button on the quick pick and supporting undefined as the URI (default state on web).