Hook up JupyterUri handle change #10017
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #10017 +/- ##
======================================
Coverage 63% 64%
======================================
Files 215 215
Lines 10122 10122
Branches 1612 1612
======================================
+ Hits 6473 6481 +8
+ Misses 3131 3121 -10
- Partials 518 520 +2
|
|
Looks like something in this PR made tests unhappy. |
rchiodo
approved these changes
May 13, 2022
DonJayamanne
force-pushed
the
hookupJupyterUriHandles
branch
from
f257729
to
d0dbabc
Compare
sadasant
reviewed
May 16, 2022
sadasant
reviewed
May 16, 2022
sadasant
reviewed
May 16, 2022
| if (this.lastSavedList) { | ||
| return this.lastSavedList; | ||
| } | ||
| const promise = async () => { |
There was a problem hiding this comment.
(tip for reviewers)
This PR reads much better with whitespaces hidden: https://github.com/microsoft/vscode-jupyter/pull/10017/files?w=1
sadasant
reviewed
May 16, 2022
| } | ||
| public async clearUriList(): Promise<void> { | ||
| this.lastSavedList = Promise.resolve([]); |
There was a problem hiding this comment.
Oh, I see the cache gets cleared here! Nice
sadasant
reviewed
May 16, 2022
sadasant
reviewed
May 16, 2022
src/test/datascience/notebook/controllers/remoteKernelControllerWatcher.unit.test.ts
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #9683
onDidChangeHandlesevent is fired, then look for controllers that belong to jupyter handles that are no longer valid. List of valid handles returned by the provider using thegetHandlesmethodgetHandlesmethod of the corresponding provider.