Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn users when files override built in packages that could have caused the kernel to fail #7538

Closed
DonJayamanne opened this issue Sep 15, 2021 · 1 comment · Fixed by #10787
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug notebook-kernel Kernels issues (start/restart/switch/execution, install ipykernel) verified Verification succeeded
Milestone

Comments

@DonJayamanne
Copy link
Contributor

We still have a large number of users running into issues resulting from creating files such as string.py, email.py, os.py, sys.py etc
I think in the past 3 weeks we had 3 users running into this issue.

This causes a lot of issues, kernel don't start or when packages get imported dynamically kernels behave weirdly.

Solution:

  • Keep a hardcoded list of reserved file names (use help('modules') to get a list of all built in modules)
    This should also help Python extension, but not sure it matters as much for Python extension.
@DonJayamanne DonJayamanne added bug Issue identified by VS Code Team member as probable bug enhancement and removed bug Issue identified by VS Code Team member as probable bug labels Sep 15, 2021
@greazer greazer added this to the October 2021 milestone Sep 16, 2021
@greazer
Copy link
Member

greazer commented Sep 16, 2021

We've seen many users run into problems due to this issue. It affects us more than plain Python files.

@greazer greazer added notebook-kernel Kernels issues (start/restart/switch/execution, install ipykernel) kernel-crash labels Oct 8, 2021
@rchiodo rchiodo modified the milestones: October 2021, November 2021 Oct 27, 2021
@rchiodo rchiodo modified the milestones: November 2021, January 2022 Dec 6, 2021
@DonJayamanne DonJayamanne self-assigned this Jan 19, 2022
@rchiodo rchiodo modified the milestones: January 2022, February 2022 Jan 25, 2022
@greazer greazer removed this from the February 2022 milestone Feb 4, 2022
@greazer greazer added feature-request Request for new features or functionality and removed enhancement labels May 4, 2022
@DonJayamanne DonJayamanne changed the title Create a diagnostic utility to warn users of file names using reserved names (built in modules) Warn users when files override built in packages that could have caused the kernel to fail Jul 14, 2022
@DonJayamanne DonJayamanne added bug Issue identified by VS Code Team member as probable bug and removed feature-request Request for new features or functionality labels Jul 14, 2022
@DonJayamanne DonJayamanne added this to the July 2022 milestone Jul 14, 2022
@amunger amunger added the verified Verification succeeded label Jul 27, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug notebook-kernel Kernels issues (start/restart/switch/execution, install ipykernel) verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants