Deprecate Thenable and alias to PromiseLike #239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TypeScript has a builtin type for promise-like values: PromiseLike. Thenable attempts to achieve the same result, but it has some compatibility issues. This change aliases Tnenable to PromiseLike, to make it compatible with the rest of the TypeScript ecosystem. Additionally this deprecates Thenable. There is no practical use case for it, but it is confusing to communicate something other than PromiseLike to users. All occurrences of Thenable were replaced with PromiseLike.
aeschli
approved these changes
Aug 26, 2024
|
Thanks @remcohaszing ! |
TylerLeonhardt
approved these changes
Aug 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TypeScript has a builtin type for promise-like values:
PromiseLike.Thenableattempts to achieve the same result, but it has some compatibility issues.This change aliases
ThenabletoPromiseLike, to make it compatible with the rest of the TypeScript ecosystem.Additionally this deprecates
Thenable. There is no practical use case for it, but it is confusing to communicate something other thanPromiseLiketo users. All occurrences ofThenablewere replaced withPromiseLike.