Skip to content

fix JS inherited property completion #155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 9, 2022
Merged

fix JS inherited property completion #155

merged 2 commits into from
Nov 9, 2022

Conversation

tamayika
Copy link
Contributor

@tamayika tamayika commented Oct 7, 2022

closes #154

I found that existing check logic does not consider JS inherited property names.

@tamayika tamayika mentioned this pull request Oct 7, 2022
Closed
2 tasks
@aeschli aeschli self-assigned this Nov 9, 2022
@aeschli aeschli added this to the November 2022 milestone Nov 9, 2022
@aeschli
Copy link
Collaborator

aeschli commented Nov 9, 2022

Thanks @tamayika !

@dbaeumer dbaeumer self-requested a review November 9, 2022 09:00
@aeschli aeschli merged commit fe255ff into microsoft:main Nov 9, 2022
@tamayika tamayika deleted the feature/154 branch November 12, 2022 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbaeumer dbaeumer dbaeumer approved these changes

@aeschli aeschli aeschli approved these changes

Assignees

@aeschli aeschli

Labels
None yet
Projects
None yet
Milestone
November 2022
Development

Successfully merging this pull request may close these issues.

Completion not shown for JS inherited property names
3 participants
@tamayika @aeschli @dbaeumer