Slow schema validation on large `oneOf` blocks

The validation is very slow when having a large `oneOf` block in the schema with lots of elements in the matching json file

https://github.com/user-attachments/assets/977de7ae-31f7-4d70-8ed8-5717028f8492

From testing this seems to be the problem (removing this makes the completion instant)

https://github.com/microsoft/vscode-json-languageservice/blob/493010da9dc2cd1cc139d403d4709d97064b17e9/src/parser/jsonParser.ts#L264-L268

JavaScript Profile:

[vscode-profile-2024-10-09-11-23-02.cpuprofile](https://github.com/user-attachments/files/17301703/vscode-profile-2024-10-09-11-23-02.cpuprofile)

Example schema with 500-1000 `oneOf`s and the json file:

[desktop-schema.json](https://github.com/user-attachments/files/17301692/desktop-schema.json)
[base.json](https://github.com/user-attachments/files/17302856/base.json)


Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Slow schema validation on large `oneOf` blocks #246

Legend-Master
openedon Oct 9, 2024

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	for (const error of this.problems) {
	if (error.code === ErrorCode.EnumValueMismatch) {
	error.message = l10n.t('Value is not accepted. Valid values: {0}.', this.enumValues.map(v => JSON.stringify(v)).join(', '));
	}
	}

Slow schema validation on large oneOf blocks #246

Description

Legend-Masteropenedon Oct 9, 2024

Metadata