feat: pretty printing #348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This kind of existed before, but it broke a while ago and had some limitations and bugs for a while. This commit improves the experience, makes it work pretty well for me locally: - Only show the pretty print command when a printable file is open in a js-debug session. - Previously, we only suggested printing ephemeral files. Now we run the minified check on files that are in the stacktrace when the user opens them, which I think is a good compromise between being apparent and being too annoying. - The ability to turn off pretty print suggestions is now a user setting. - Previously if you were on a breakpoint and then pretty-printed a file, continuing to step through would return to the original file, and any breakpoints in the minified file would not be updated. We fix that by moving the "original location" of breakpoints into the beauitified file. - Added tests for pretty printing. - There were several edge cases around how we handled pretty print commands for file on disk and for multiple debug sessions, those should be fixed here. Something that doesn't work yet is the preservation of breakpoints in beauitified sources on reload. To do this, I think we need to have some extra logic to watch for breakpoints set in *-pretty.js files, and then generate the beautified source automatically when we see a source matching those breakpoints. For a followup PR.
roblourens
approved these changes
Feb 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This kind of existed before, but it broke a while ago and had some
limitations and bugs for a while. This commit improves the experience,
makes it work pretty well for me locally:
a js-debug session.
minified check on files that are in the stacktrace when the user
opens them, which I think is a good compromise between being apparent
and being too annoying.
continuing to step through would return to the original file, and
any breakpoints in the minified file would not be updated. We fix that
by moving the "original location" of breakpoints into the beauitified
file.
commands for file on disk and for multiple debug sessions,
those should be fixed here.
Something that doesn't work yet is the preservation of breakpoints in
beauitified sources on reload. To do this, I think we need to have some
extra logic to watch for breakpoints set in *-pretty.js files, and then
generate the beautified source automatically when we see a source
matching those breakpoints. For a followup PR.
Demo: https://memes.peet.io/img/bc0c485e-323b-44a7-bc2d-bd274ba2344c.mp4