feat: disable certificate validation for localhost #332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also improves the `isLoopback` check to do a DNS lookup to handle any hosts configuration or exotic addresses. Fixes #309
connor4312
force-pushed
the
disable-validation-on-loopback
branch
from
159f3f6 to
4c2f56c
Compare
EricCornelson
approved these changes
Feb 13, 2020
src/common/urlUtils.ts
Outdated
| const driver = url.startsWith('https://') ? https : http; | ||
| const isInsecure = url.startsWith('http://'); | ||
| const driver = isInsecure ? http : https; | ||
| const rejectUnauthorized = !isInsecure && !(await isLoopback(url)); |
There was a problem hiding this comment.
nit: double negative on the isInsecure, would read easier if it was flipped to isSecure
roblourens
approved these changes
Feb 13, 2020
connor4312
force-pushed
the
disable-validation-on-loopback
branch
from
09931b1 to
3febde3
Compare
connor4312
force-pushed
the
disable-validation-on-loopback
branch
from
3febde3 to
125376e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also improves the
isLoopbackcheck to do a DNS lookup to handle anyhosts configuration or exotic addresses.
Fixes #309