feat: request async stacks lazily to speed up terminal commands #237
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tl;dr of the investigation from #120 was that the big culprit of slower commands in the terminal were async stack traces. In this PR, we introduce logic, enabled by default in the terminal, which does not turn on async stack tracking until a breakpoint is hit or the debugger pauses, whichever happens first. This allows standard build commands like Webpack to run much faster if the developer is using the debugger terminal like any other terminal and isn't interested in debugging the current task. On my machine it reduces debug overhead from 120% to 30%: ``` PS > Measure-Command { webpack } Normal Terminal: 12.46 / 12.16 / 13.07 Debugger Terminal (master): 22.58 / 23.33 / 22.82 (2.2x) Debugger Terminal (this PR): 16.90 / 16.86 / 16.71 (1.3x) ```
connor4312
force-pushed
the
feat/lazy-async-stacks
branch
from
17ad7e4 to
30875cc
Compare
roblourens
approved these changes
Jan 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tl;dr of the investigation from #120 was that the big culprit of slower
commands in the terminal were async stack traces. In this PR, we
introduce logic, enabled by default in the terminal, which does not turn
on async stack tracking until a breakpoint is hit or the debugger
pauses, whichever happens first.
This allows standard build commands like Webpack to run much faster if
the developer is using the debugger terminal like any other terminal and
isn't interested in debugging the current task.
On my machine it reduces debug overhead from 120% to 30%:
Fixes #120