Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ This changelog records changes to stable releases since 1.50.2. "TBA" changes he
- fix: explicitly specify completion ranges ([[vscode#243409](https://github.com/microsoft/vscode/issues/243409)])
- fix: memory leak between debug sessions ([#2173](https://github.com/microsoft/vscode-js-debug/issues/2173))
- fix: support `npm.scriptRunner: node`
- chore: enable experimental networking by default on recent Node versions

## 1.97 (January 2025)

Expand Down
4 changes: 4 additions & 0 deletions src/binder.ts
Original file line number Diff line number Diff line change
Expand Up @@ -174,6 +174,10 @@ export class Binder implements IDisposable {

return {};
});
dap.on('enableNetworking', () => {
// handled on a session level
return Promise.resolve({});
});
}

private readonly getLaunchers = once(() => {
Expand Down
2 changes: 1 addition & 1 deletion src/build/generate-contributions.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1252,7 +1252,7 @@ const configurationSchema: ConfigurationAttributes<IConfigurationTypes> = {
},
[Configuration.EnableNetworkView]: {
type: 'boolean',
default: false,
default: true,
description: refString('configuration.enableNetworkView'),
},
};
Expand Down
10 changes: 3 additions & 7 deletions src/targets/node/nodeBinaryProvider.ts
Original file line number Diff line number Diff line change
Expand Up @@ -132,13 +132,9 @@ export class NodeBinary {
this.capabilities.add(Capability.UseInspectPublishUid);
}

// todo@connor4312: the current API we get in Node.js is pretty tiny and
// I don't want to ship it by default in its current version, ref
// https://github.com/nodejs/node/pull/53593#issuecomment-2276367389
// Users can still turn it on by setting `experimentalNetworking: on`.
// if (version.gte(new Semver(22, 6, 0)) && version.lt(new Semver(24, 0, 0))) {
// this.capabilities.add(Capability.UseExperimentalNetworking);
// }
if (version.gte(new Semver(22, 14, 0)) && version.lt(new Semver(24, 0, 0))) {
this.capabilities.add(Capability.UseExperimentalNetworking);
}
}

/**
Expand Down
Loading