feat: Support Junit 5 meta-annotations and composed annotations #756
Conversation
| * @param annotationToSearch The annotation string. | ||
| * @param checkHierarchy Specify whether to search the whole annotation hierarchy. | ||
| */ | ||
| public static boolean hasAnnotation(IMember member, String annotationToSearch, boolean checkHierarchy) { |
There was a problem hiding this comment.
Would Inherited be more proper than hierarchy? e.g. checkInherited
There was a problem hiding this comment.
includeInherited looks even better.
There was a problem hiding this comment.
Hmm, actually the annotation we treated here is not inherited. That's why it is called meta-annotation.
There was a problem hiding this comment.
exactly, not inherited. From the saying meta-annotation, it's annotation of an annotation, and it is, more like aggregation/combination.
Anyway, use whatever proper name you like.
Eskibear
left a comment
Eskibear
left a comment
There was a problem hiding this comment.
LGTM.
Suggest to add test cases to guard the utitilities later.
| } | ||
| for (final String annotation : this.testMethodAnnotations) { | ||
| if (TestFrameworkUtils.hasAnnotation(method, annotation)) { | ||
| if (TestFrameworkUtils.hasAnnotation(method, annotation, false /*checkHierarchy*/)) { |
There was a problem hiding this comment.
Actually you might simply overload hasAnnotation, to avoid changing these statements.
boolean hasAnnotation(method, anno) {
return hasAnnotation(method, anno, false);
}
boolean hasAnnotation(method, anno, boolean) {
// ...
}
resolve #737
By searching the annotation hierarchy, we can resolve the meta-annotation scenario.