Skip to content

Get ASTNode from ASTProvider #1052

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jdneo merged 2 commits into from
Aug 31, 2020
Merged

Get ASTNode from ASTProvider #1052

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2cd093b
Get ASTNode from ASTProvider
jdneo Aug 31, 2020
dafc313
Fix test error
jdneo Aug 31, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 11 additions & 6 deletions ...t.java.test.plugin/src/main/java/com/microsoft/java/test/plugin/util/TestSearchUtils.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@
import org.eclipse.jdt.core.dom.CompilationUnit;
import org.eclipse.jdt.core.dom.ITypeBinding;
import org.eclipse.jdt.core.dom.TypeDeclaration;
import org.eclipse.jdt.core.manipulation.CoreASTProvider;
import org.eclipse.jdt.core.search.IJavaSearchConstants;
import org.eclipse.jdt.core.search.IJavaSearchScope;
import org.eclipse.jdt.core.search.SearchEngine;
Expand Down Expand Up @@ -111,12 +112,16 @@ public static List<TestItem> searchCodeLens(List<Object> arguments, IProgressMon
}

public static ASTNode parseToAst(final ICompilationUnit unit, IProgressMonitor monitor) {
final ASTParser parser = ASTParser.newParser(AST.JLS14);
parser.setSource(unit);
parser.setFocalPosition(0);
parser.setResolveBindings(true);
parser.setIgnoreMethodBodies(true);
return parser.createAST(monitor);
final CompilationUnit astRoot = CoreASTProvider.getInstance().getAST(unit, CoreASTProvider.WAIT_YES, monitor);
Copy link
Contributor

@testforstephen testforstephen Aug 31, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there any difference if setting to WAIT_NO?

Copy link
Member Author

@jdneo jdneo Aug 31, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check and not very significant difference observed

if (astRoot == null) {
final ASTParser parser = ASTParser.newParser(AST.JLS14);
parser.setSource(unit);
parser.setFocalPosition(0);
parser.setResolveBindings(true);
parser.setIgnoreMethodBodies(true);
return parser.createAST(monitor);
}
return astRoot;
}

/**
Expand Down
2 changes: 1 addition & 1 deletion test/test-projects/modular-gradle/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ repositories {
}

dependencies {
testImplementation('org.junit.jupiter:junit-jupiter:5.5.2')
testImplementation('org.junit.jupiter:junit-jupiter:5.6.0')
}

test {
Expand Down