Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initialize the classpath configuration page #567

Merged
merged 1 commit into from
Mar 17, 2021
Merged

Conversation

jdneo
Copy link
Member

@jdneo jdneo commented Mar 15, 2021

image

Signed-off-by: Sheng Chen sheche@microsoft.com

Signed-off-by: Sheng Chen <sheche@microsoft.com>
referenceLibraries: string[];
}

export enum ProjectType {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same enum used in Runtime webview. Consider to extract...

Others = "Others",
}

export enum NatureId {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure I'll extract them in the next PR.

@jdneo jdneo merged commit 25f64dc into master Mar 17, 2021
@jdneo jdneo deleted the cs/classpath-config branch March 17, 2021 03:24
@jdneo jdneo mentioned this pull request Apr 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants