Skip to content

refactor: Use factory pattern to create explorer nodes#731

Merged
jdneo merged 2 commits intomainfrom
cs/node-factory
Apr 6, 2023
Merged

refactor: Use factory pattern to create explorer nodes#731
jdneo merged 2 commits intomainfrom
cs/node-factory

Conversation

@jdneo
Copy link
Member

@jdneo jdneo commented Apr 4, 2023

  • Use factory pattern to create nodes. This can remove a lot of duplicated codes.
  • Redefine the NodeKind enum to better sort the nodes in explorer

jdneo added 2 commits April 4, 2023 16:38
Signed-off-by: Sheng Chen <sheche@microsoft.com>
@jdneo jdneo added this to the 0.22.0 milestone Apr 4, 2023
@jdneo jdneo added the eng engineering label Apr 4, 2023
Copy link
Member

@Eskibear Eskibear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

much more clear

@jdneo jdneo merged commit 61333f2 into main Apr 6, 2023
@jdneo jdneo deleted the cs/node-factory branch April 6, 2023 01:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

eng engineering

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants